feat: add tags counters in filtering panel labels#94
Open
Delapouite wants to merge 1 commit intoorg-roam:mainfrom
Open
feat: add tags counters in filtering panel labels#94Delapouite wants to merge 1 commit intoorg-roam:mainfrom
Delapouite wants to merge 1 commit intoorg-roam:mainfrom
Conversation
Contributor
|
Hmmm, I'm not sure how I feel about this. On the one hand it's neat, but I wonder how much extra information this adds. For me it would say something like (4/79), which does not really add that much information for me. I think just displaying the amount of tags could be sufficient. In what way do you use this info? Also, if you have any other improvement suggestions (or, even better, PRs) for the tags panel I would be estatic, I've been quite unhappy with how it's implemented. It's too obscure (needs like 4 clicks to get there) and having white and blacklists separate doesn't really make sense to me, i'd rather see something like "+#tag1 -#tag2". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello
This is a small improvement to display the number of filtered tags in the dedicated panels.
Here's what it looks like (I have 28 tags in my example) :